Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT-1028 - 1995 spool file - modify spool file header benefit type #20329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GcioGregg
Copy link
Contributor

@GcioGregg GcioGregg commented Jan 16, 2025

Summary

  • This work is behind a feature toggle (flipper): YES/NO NO
  • VEBT-1028 - 1995 spool file - modify spool file header benefit type
  • (If bug, how to reproduce) N/A
  • shorten the benefit type in spool header per edu request
  • VEBT
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • was showing longer name for each benefit type in header section of 1995 spool file
  • submit a 1995 form and check resulting spool file benefit types

What areas of the site does it impact?

1995 spool file

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@va-vfs-bot va-vfs-bot temporarily deployed to vebt-1028-update-spool-file-header/main/main January 16, 2025 20:01 Inactive
@GcioGregg GcioGregg changed the title modify spool file header for 1995 VEBT-1028 - 1995 spool file - modify spool file header benefit type Jan 16, 2025
@@ -17,6 +18,12 @@ def school
@applicant.newSchool
end

def header_abbreviated_form_type(header_form_type)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GcioGregg is there a test that covers this method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenjcumming the fixtures that represent the spool file output cover testing that method. There is at least one fixture/spool file (*.spl) for every entry in the hash used by this method. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants